Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0 | Make isset, unset and empty parenthesis owners #23

Open
jrfnl opened this issue Nov 8, 2023 · 0 comments
Open

4.0 | Make isset, unset and empty parenthesis owners #23

jrfnl opened this issue Nov 8, 2023 · 0 comments

Comments

@jrfnl
Copy link
Member

jrfnl commented Nov 8, 2023

Repost from squizlabs/PHP_CodeSniffer#3118:

I was just wondering why isset(), unset() and empty() - all language constructs which require parentheses - are not considered parentheses owners.

Would it make sense to change that ? Should be a relatively easy change to make as far as I can see.

Happy to make the changes if there is interest.


[Edit]: Might be useful to include exit(), die() and eval() as well, though these three don't require parentheses, but are "owners" when the parentheses are present.


See the original post for some pointers about the implementation.

@jrfnl jrfnl added this to the 4.0.0 milestone Nov 8, 2023
@jrfnl jrfnl changed the title Suggestion: make isset, unset and empty parenthesis owners 4.0 | Make isset, unset and empty parenthesis owners Nov 8, 2023
@jrfnl jrfnl self-assigned this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant