Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0 | Tests: flag tests which would lead to fixes, but are missing a fixed test case file #300

Open
jrfnl opened this issue Jan 23, 2024 · 1 comment

Comments

@jrfnl
Copy link
Member

jrfnl commented Jan 23, 2024

Inspired by a remark from @fredden in #289 and related to #25, the PHPCS native AbstractSniffUnitTest test case should flag sniff test case files which would lead to fixes, but for which no .fixed file is available to verify the fixes against.

As there are numerous external standards which use the PHPCS native test framework for their own sniff tests, this new failure message should go into PHPCS 4.0 as it is likely to cause test failures for external standards, which may be missing .fixed files for some of their sniff tests.

Also note that the same applies to PHPCS itself (currently missing 5 .fixed files). Issue #299 has been opened to address these and will need to be resolved before the fix for this issue can be merged.

@jrfnl
Copy link
Member Author

jrfnl commented Jan 23, 2024

Note: I have already prepared a fix for this, but won't pull it until #299 has been addressed.

Also note that #25 may warrant changes to the fix currently prepared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant