Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: exclude Windows / Composer v1 / PHP 5.5 from builds #181

Closed
jrfnl opened this issue May 27, 2022 · 2 comments · Fixed by #183
Closed

CI: exclude Windows / Composer v1 / PHP 5.5 from builds #181

jrfnl opened this issue May 27, 2022 · 2 comments · Fixed by #183

Comments

@jrfnl
Copy link
Member

jrfnl commented May 27, 2022

The Windows / Composer v1 / PHP 5.5 build keeps failing CI runs semi-randomly, causing more and more exceptions for that particular combi to be added to the test suite.

I'm tempted to remove it from the CI for the following reasons:

  1. I suspect that that combination will be rare in real life anyway as most users of PHP 5.5 will have upgraded to Composer 2.2.x by now.
  2. The principle is still being tested on all the other OS/Composer combinations with PHP 5.5 and should safeguard things well enough.
  3. The functionality of the plugin isn't actually failing on this combi, it's just that Composer is not writing the expected messages to the CLI, even though the plugin does do its job.

Opinions ?

@jrfnl
Copy link
Member Author

jrfnl commented Jun 24, 2022

@Potherca ?

@Potherca
Copy link
Member

Thanks for the ping! This had somehow fallen of my radar. 😥

I'm tempted to remove it from the CI for the following reasons

I concur, remove at will. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants