Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the root package for sniffs to install #20

Closed
Potherca opened this issue Mar 9, 2017 · 2 comments
Closed

Check the root package for sniffs to install #20

Potherca opened this issue Mar 9, 2017 · 2 comments
Assignees
Milestone

Comments

@Potherca
Copy link
Member

Potherca commented Mar 9, 2017

Problem/Motivation

As described in #19, the installer does not look in the root package. As it is completely viable for root packages to contain a code sniff, the installer should also check the root package.

Expected behaviour / Actual behaviour / Steps to reproduce

Not applicable.

Proposed changes

A separate step needs to be implemented that checks the root package to see if it contains any sniffs that (also) need installing.

@frenck
Copy link
Contributor

frenck commented May 9, 2017

Added this feature in PR #25 and is waiting code review.

@frenck frenck self-assigned this May 10, 2017
@frenck
Copy link
Contributor

frenck commented May 10, 2017

Merged into the master branch and will in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants