Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds PHP_CodeSniffer version constraints #77

Merged
merged 1 commit into from Oct 26, 2018
Merged

Adds PHP_CodeSniffer version constraints #77

merged 1 commit into from Oct 26, 2018

Conversation

frenck
Copy link
Contributor

@frenck frenck commented Oct 26, 2018

Proposed Changes

From TravisCI build ouput:

$ composer validate
./composer.json is valid, but with a few warnings
See https://getcomposer.org/doc/04-schema.md for details on the schema
require.squizlabs/php_codesniffer : unbound version constraints (*) should be avoided

This PR adds version constraints to avoid that warning. Also, this plugin is currently only compatible with 2.x and 3.x of PHP_CodeSniffer.

Related Issues

n/a

@frenck frenck merged commit e749410 into master Oct 26, 2018
@frenck frenck deleted the phpcs-version-contraints branch October 26, 2018 13:21
@frenck frenck self-assigned this Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frenck frenck

Labels
improvement
Projects
None yet
Milestone
Release v0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frenck @Potherca