Add support for a string phpcodesniffer-search-depth config value set via composer config
#85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potherca
reviewed
Sep 10, 2019
Potherca
previously approved these changes
Sep 11, 2019
|
To get Travis passing MR #86 needs to be merged. |
|
Awaiting MR #86, these changes can be seen to pass the build in Travis. |
|
Could you please rebase this on master, because the build issues have been resolved |
…n order to support setting it with `composer config`.
TravisCarden
force-pushed
the
issue-82
branch
from
89a525e
to
248bee8
Compare
|
Rebased, @mjrider. |
Potherca
approved these changes
Sep 22, 2019
Potherca
modified the milestones:
Release v0.5.1 (Next Minor Release),
Release v0.6.0 (Next Major Release)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add support for a string value of the
extra.phpcodesniffer-search-depthconfig value so it can be set from the command line (composer config).Related Issues
#82