Merge pull request #1637 from PHPCompatibility/php-8.3/new-functions-…

…new-constants-pgsql PHP 8.3 | NewFunctions/NewConstants: detect new PGSQL features
PHPCompatibility · Sep 10, 2023 · 52d8b39 · 52d8b39
2 parents 0557008 + 7d55d25
commit 52d8b39
Show file tree

Hide file tree

Showing 6 changed files with 84 additions and 0 deletions.
diff --git a/PHPCompatibility/Sniffs/Constants/NewConstantsSniff.php b/PHPCompatibility/Sniffs/Constants/NewConstantsSniff.php
@@ -7706,6 +7706,41 @@ class NewConstantsSniff extends Sniff
             'extension' => 'sockets',
         ],
 
+        'PGSQL_PIPELINE_SYNC' => [
+            '8.2'       => false,
+            '8.3'       => true,
+            'extension' => 'pgsql',
+        ],
+        'PGSQL_PIPELINE_ON' => [
+            '8.2'       => false,
+            '8.3'       => true,
+            'extension' => 'pgsql',
+        ],
+        'PGSQL_PIPELINE_OFF' => [
+            '8.2'       => false,
+            '8.3'       => true,
+            'extension' => 'pgsql',
+        ],
+        'PGSQL_PIPELINE_ABORTED' => [
+            '8.2'       => false,
+            '8.3'       => true,
+            'extension' => 'pgsql',
+        ],
+        'PGSQL_SHOW_CONTEXT_NEVER' => [
+            '8.2'       => false,
+            '8.3'       => true,
+            'extension' => 'pgsql',
+        ],
+        'PGSQL_SHOW_CONTEXT_ERRORS' => [
+            '8.2'       => false,
+            '8.3'       => true,
+            'extension' => 'pgsql',
+        ],
+        'PGSQL_SHOW_CONTEXT_ALWAYS' => [
+            '8.2'       => false,
+            '8.3'       => true,
+            'extension' => 'pgsql',
+        ],
         'POSIX_SC_ARG_MAX' => [
             '8.2'       => false,
             '8.3'       => true,

diff --git a/PHPCompatibility/Sniffs/FunctionUse/NewFunctionsSniff.php b/PHPCompatibility/Sniffs/FunctionUse/NewFunctionsSniff.php
@@ -4938,6 +4938,31 @@ class NewFunctionsSniff extends Sniff
             '8.3'       => true,
             'extension' => 'mbstring',
         ],
+        'pg_set_error_context_visibility' => [
+            '8.2'       => false,
+            '8.3'       => true,
+            'extension' => 'pgsql',
+        ],
+        'pg_enter_pipeline_mode' => [
+            '8.2'       => false,
+            '8.3'       => true,
+            'extension' => 'pgsql',
+        ],
+        'pg_exit_pipeline_mode' => [
+            '8.2'       => false,
+            '8.3'       => true,
+            'extension' => 'pgsql',
+        ],
+        'pg_pipeline_sync' => [
+            '8.2'       => false,
+            '8.3'       => true,
+            'extension' => 'pgsql',
+        ],
+        'pg_pipeline_status' => [
+            '8.2'       => false,
+            '8.3'       => true,
+            'extension' => 'pgsql',
+        ],
         'posix_sysconf' => [
             '8.2'       => false,
             '8.3'       => true,

diff --git a/PHPCompatibility/Tests/Constants/NewConstantsUnitTest.inc b/PHPCompatibility/Tests/Constants/NewConstantsUnitTest.inc
@@ -1558,3 +1558,10 @@ echo POSIX_PC_CHOWN_RESTRICTED;
 echo POSIX_PC_NO_TRUNC;
 echo POSIX_PC_ALLOC_SIZE_MIN;
 echo POSIX_PC_SYMLINK_MAX;
+echo PGSQL_SHOW_CONTEXT_NEVER;
+echo PGSQL_SHOW_CONTEXT_ERRORS;
+echo PGSQL_SHOW_CONTEXT_ALWAYS;
+echo PGSQL_PIPELINE_SYNC;
+echo PGSQL_PIPELINE_ON;
+echo PGSQL_PIPELINE_OFF;
+echo PGSQL_PIPELINE_ABORTED;
diff --git a/PHPCompatibility/Tests/Constants/NewConstantsUnitTest.php b/PHPCompatibility/Tests/Constants/NewConstantsUnitTest.php
@@ -1631,6 +1631,13 @@ public static function dataNewConstant()
             ['POSIX_PC_NO_TRUNC', '8.2', 1558, '8.3'],
             ['POSIX_PC_ALLOC_SIZE_MIN', '8.2', 1559, '8.3'],
             ['POSIX_PC_SYMLINK_MAX', '8.2', 1560, '8.3'],
+            ['PGSQL_SHOW_CONTEXT_NEVER', '8.2', 1561, '8.3'],
+            ['PGSQL_SHOW_CONTEXT_ERRORS', '8.2', 1562, '8.3'],
+            ['PGSQL_SHOW_CONTEXT_ALWAYS', '8.2', 1563, '8.3'],
+            ['PGSQL_PIPELINE_SYNC', '8.2', 1564, '8.3'],
+            ['PGSQL_PIPELINE_ON', '8.2', 1565, '8.3'],
+            ['PGSQL_PIPELINE_OFF', '8.2', 1566, '8.3'],
+            ['PGSQL_PIPELINE_ABORTED', '8.2', 1567, '8.3'],
         ];
     }
 

diff --git a/PHPCompatibility/Tests/FunctionUse/NewFunctionsUnitTest.inc b/PHPCompatibility/Tests/FunctionUse/NewFunctionsUnitTest.inc
@@ -1048,3 +1048,8 @@ posix_sysconf();
 posix_pathconf();
 posix_fpathconf();
 posix_eaccess();
+pg_set_error_context_visibility();
+pg_enter_pipeline_mode();
+pg_exit_pipeline_mode();
+pg_pipeline_sync();
+pg_pipeline_status();
diff --git a/PHPCompatibility/Tests/FunctionUse/NewFunctionsUnitTest.php b/PHPCompatibility/Tests/FunctionUse/NewFunctionsUnitTest.php
@@ -1109,6 +1109,11 @@ public static function dataNewFunction()
             ['posix_pathconf', '8.2', 1048, '8.3'],
             ['posix_fpathconf', '8.2', 1049, '8.3'],
             ['posix_eaccess', '8.2', 1050, '8.3'],
+            ['pg_set_error_context_visibility', '8.2', 1051, '8.3'],
+            ['pg_enter_pipeline_mode', '8.2', 1052, '8.3'],
+            ['pg_exit_pipeline_mode', '8.2', 1053, '8.3'],
+            ['pg_pipeline_sync', '8.2', 1054, '8.3'],
+            ['pg_pipeline_status', '8.2', 1055, '8.3'],
         ];
     }