Merge pull request #786 from PHPCompatibility/php-7.3.1/new-functions

FunctionUse/NewFunctions: add new OCI functions
PHPCompatibility · Jan 13, 2019 · f8a1518 · f8a1518
2 parents 4487042 + f85a086
commit f8a1518
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 0 deletions.
diff --git a/PHPCompatibility/Sniffs/FunctionUse/NewFunctionsSniff.php b/PHPCompatibility/Sniffs/FunctionUse/NewFunctionsSniff.php
@@ -1746,6 +1746,16 @@ class NewFunctionsSniff extends AbstractNewFeatureSniff
             '7.1' => false,
             '7.2' => true,
         ),
+        // Introduced in 7.2.14 and 7.3.1 similtanously.
+        'oci_set_call_timeout' => array(
+            '7.2.13' => false,
+            '7.2.14' => true,
+        ),
+        // Introduced in 7.2.14 and 7.3.1 similtanously.
+        'oci_set_db_operation' => array(
+            '7.2.13' => false,
+            '7.2.14' => true,
+        ),
 
         'hrtime' => array(
             '7.2' => false,

diff --git a/PHPCompatibility/Tests/FunctionUse/NewFunctionsUnitTest.inc b/PHPCompatibility/Tests/FunctionUse/NewFunctionsUnitTest.inc
@@ -473,3 +473,6 @@ ldap_mod_add_ext();
 ldap_mod_replace_ext();
 ldap_mod_del_ext();
 ldap_rename_ext();
+
+oci_set_call_timeout();
+oci_set_db_operation();
diff --git a/PHPCompatibility/Tests/FunctionUse/NewFunctionsUnitTest.php b/PHPCompatibility/Tests/FunctionUse/NewFunctionsUnitTest.php
@@ -526,6 +526,9 @@ public function dataNewFunction()
             array('ldap_mod_replace_ext', '7.2', array(473), '7.3'),
             array('ldap_mod_del_ext', '7.2', array(474), '7.3'),
             array('ldap_rename_ext', '7.2', array(475), '7.3'),
+
+            array('oci_set_call_timeout', '7.2.13', array(477), '7.3', '7.2'),
+            array('oci_set_db_operation', '7.2.13', array(478), '7.3', '7.2'),
         );
     }