Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level of Break #455

Closed
2shediac opened this issue May 23, 2017 · 3 comments
Closed

Level of Break #455

2shediac opened this issue May 23, 2017 · 3 comments
Labels

Comments

@2shediac
Copy link

Hi - wondering if the level of break in version 7.0x is checked. Also is there a way to suppress the default timezone message.

@MarkMaldaba
Copy link
Contributor

Also is there a way to suppress the default timezone message.

It's always advisable to report different problems as separate issues, so they can be dealt with separately. I have logged issue #457 to handle improving or removing the default timezone tests.

In the meantime, you can suppress unwanted errors via various standard mechanisms provided by PHP CodeSniffer, e.g. a custom ruleset.xml.

@jrfnl
Copy link
Member

jrfnl commented May 23, 2017

wondering if the level of break in version 7.0x is checked.

As far as I know, you can still break out of multiple loops in one go by using a number. This has not changed in PHP 7.
If you believe differently, could you please point me to some documentation/changelog to support that ?

@wimg
Copy link
Member

wimg commented May 25, 2017

As mentioned here : http://php.net/manual/en/control-structures.break.php
break with a numerical argument (break $param;) is not allowed since 5.4 and break 0 is not allowed either since PHP 5.4
Both of these are checked for.
The timezone sniff has been removed.

@wimg wimg closed this as completed May 25, 2017
@jrfnl jrfnl added the invalid label Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants