Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report use of nowdoc strings in PHP < 5.3 #48

Closed
MarkMaldaba opened this issue Mar 5, 2015 · 2 comments
Closed

Report use of nowdoc strings in PHP < 5.3 #48

MarkMaldaba opened this issue Mar 5, 2015 · 2 comments
Milestone

Comments

@MarkMaldaba
Copy link
Contributor

PHP added support for nowdoc strings[1] in PHP 5.3, so a Sniff should be added to report an error if targeting earlier versions.

[1] http://php.net/manual/en/language.types.string.php#language.types.string.syntax.nowdoc

@MarkMaldaba
Copy link
Contributor Author

Also, the use of heredoc quoted strings (e.g. <<<"EOF" instead of <<<EOF) also introduced in PHP 5.3 (the old heredoc style without quotes has been around since PHP 4, so doesn't need a check).

Perhaps this should be a separate ticket?

@MarkMaldaba MarkMaldaba changed the title Detect use of nowdoc strings. Detect use of nowdoc strings in PHP < 5.3 Mar 5, 2015
@MarkMaldaba MarkMaldaba changed the title Detect use of nowdoc strings in PHP < 5.3 Report use of nowdoc strings in PHP < 5.3 Mar 5, 2015
@wimg wimg closed this as completed in dfb1b71 Jun 29, 2016
@jrfnl
Copy link
Member

jrfnl commented Mar 21, 2017

Also, the use of heredoc quoted strings (e.g. <<<"EOF" instead of <<<EOF) also introduced in PHP 5.3

FYI: I've got the code ready in the backwings to add sniffing for this to the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants