This repository has been archived by the owner on Jan 2, 2019. It is now read-only.
Fix invalid NA return in VLOOKUP #423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VLOOKUP function required the lookup value to be the same type as the return value which has been corrected. Optimized variable usage
|
I agree: What is returned does not and should not depend in any way on the type of what is being looked for. The documentation also doesn't mention anything about this. The behaviour of |
|
👍 |
8823-scholar
added a commit
to befool-inc/PHPExcel
that referenced
this pull request
Nov 7, 2014
|
Merged manually, thanks for the fix |
|
Merged manually |
|
Would be nice to tag/release |
|
Ouch, took me a while to figure the problem was vlookup in a complex document and I had the https://phpexcel.codeplex.com/ version without this fix. Glad I found this post fast after all that time, ty. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VLOOKUP function required the lookup value to be the same type as the return value which has been corrected.
Removed redundant $result variable