Skip to content
This repository has been archived by the owner on Jan 2, 2019. It is now read-only.

Fix invalid NA return in VLOOKUP #423

Closed
wants to merge 1 commit into from

Conversation

frozenstupidity
Copy link

The VLOOKUP function required the lookup value to be the same type as the return value which has been corrected.

Removed redundant $result variable

The VLOOKUP function required the lookup value to be the same type as the return value which has been corrected.

Optimized variable usage
@jumoel
Copy link

jumoel commented Oct 30, 2014

I agree: What is returned does not and should not depend in any way on the type of what is being looked for. The documentation also doesn't mention anything about this.

The behaviour of VLOOKUP with this patch is now also matching the behaviour of HLOOKUP.

@8823-scholar
Copy link

👍

8823-scholar added a commit to befool-inc/PHPExcel that referenced this pull request Nov 7, 2014
MarkBaker pushed a commit that referenced this pull request Nov 12, 2014
@MarkBaker
Copy link
Member

Merged manually, thanks for the fix

@MarkBaker
Copy link
Member

Merged manually

@MarkBaker MarkBaker closed this Nov 13, 2014
@umpirsky
Copy link

Would be nice to tag/release 1.8.1 with this fix in place so we don't have to depend on master.

@danielocdh
Copy link

Ouch, took me a while to figure the problem was vlookup in a complex document and I had the https://phpexcel.codeplex.com/ version without this fix. Glad I found this post fast after all that time, ty.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants