Fix. Text is subscripted when set superscript to false #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 0.8.0
Reset the subscript to false only when superscript is true Reset the superscript to false only when subscript is true Update Testcases
Closed
Progi1984
added a commit
to Progi1984/PHPPresentation
that referenced
this pull request
Aug 23, 2017
polidog
pushed a commit
to polidog/PHPPresentation
that referenced
this pull request
Oct 14, 2019
* Fix. Text is subscripted when set superscript to false Reset the subscript to false only when superscript is true Reset the superscript to false only when subscript is true Update Testcases * Fix. Some coding style issues * Fix. Use space insteadof tab * Remove temp file tempnam() creates a file that is not removed. Only $pFilename . '.xlsx' is removed by $this->writeSpreadsheet(). * PHP 5.3 is not supported anymore by Travis CI : https://docs.travis-ci.com/user/languages/php/ * PHPOffice#382 : Improve tests for validating the OOXML Schema * PHPOffice#382 : Validation for Open XML * PHPOffice#382 : Validation for Open XML * PHPOffice#382 : Validation for OpenDocument * PHPOffice#382 : OpenXML (ISO 29500-1 Strict) * PHPOffice#382 : OpenXML (ISO 29500-1 Strict) * FIXED : Missing argument 1 for phpDocumentor\Descriptor\Collection::get() * PHPOffice#360 : Changelog * PHPOffice#397 : PowerPoint2007 Reader : Background Color based on SchemeColor * PHPOffice#355 : Doughnut Chart * PHPOffice#355 : Doughnut Chart (Changelog & Tests & WIP ODPresentation) * PHPOffice#355 : - ODPresentation Writer : Doughnut Chart - ODPresentation Writer : Support for the position of Legend * PHPOffice#355 : Fix PHPCS * PHPOffice#355 : Array to string conversion (PHPPresentation/src/PhpPresentation/Writer/PowerPoint2007/LayoutPack/TemplateBased.php:73) * PHPOffice#355 : PHP 7.1 is now supported * PHPOffice#370 : PhpOffice\PhpPresentation\Style\Color : Define only the transparency * PHPOffice#370 : PowerPoint2007 Writer : Support for fill for transparent image * PHPOffice#370 : ODPresentation Writer : Support for fill for transparent image * PHPOffice#370 : ODPresentation Reader : Support for fill for image * PHPOffice#370 : PowerPoint2007 Reader : Support for fill for image * PHPOffice#382 : PowerPoint2007 Writer (Validation) * PHPOffice#382 : Replacement PHPDoc (return self => return ) * PHPOffice#382 : Replacement (rand => mt_rand) * PHPOffice#382 : ODPresentation Writer (Validation) * PHPOffice#382 : ODPresentation Writer (Validation) * PHPOffice#382 : PHPCS Fixes * PHPOffice#382 : PHPUnit fixes (PHP 5.4) * refactoring and reducing cyclomatic complexity * remove extra space * adding new line at the end of the file * Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase * PHPOffice#382 : Fixes nefore merge * PHPOffice#382 : Fixes Sample 20 * problems accessing files the casing didn't match the case of the folder names. the vendor autoload is in a different folder... * Update Sample_Header.php * Update Sample_Header.php * Update Sample_Header.php * Update Sample_Header.php added some checks to make sure that the sample outputs are set up correctly. * Update Sample_Header.php more checks to make sure the sample code can run * Fixes some CS * Refactoring tests * Trailing whitespaces Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com> * Remove extra lines Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com> * Simplify return * Change group shape extents to reflect content width/height. Previously the group extents where calculated based on the extents of the containing shapes using the slide/container of the group as the point of reference. This would result in the group being larger than needed; especially noticable for a large X or Y offest. * Remove % signs from PptCharts to fix chart generation. Fixes PHPOffice#452 * Solve Problems with png transparencies * Update .travis.yml * Use proper name for `ext-gd` `ext-gd2` is not recognized by composer and should instead be `ext-gd`. * Create auto_assign.yml * Fix PHP Docs * Fix Regression PHP Docs int->float * Fix double aray in PHPDocs Fix Typing * Update .travis.yml * FIXED : Validation of the composer.json * PHPOffice#382 Update Composer * PHPOffice#382 : Fixes ECMA-376 * PHPOffice#382 : Fixes ECMA-376 * PHPOffice#382 : Fixes OpenDocument * PHPOffice#382 : Fixes OpenDocument * Update composer.json * Update composer.json * Composer : PHPUnit * PHPOffice#382 : Remove options not compatible with latest phpunit version * PHPOffice#382 : TypeError: Argument 2 passed to PHPUnit\Framework\Assert::assertFileExists() must be of the type string, null given * PHPOffice#382 : The each() function is deprecated. This message will be suppressed on further calls * PHPOffice#382 : Error: Call to undefined method PhpOffice\PhpPresentation\Tests\Style\AlignmentTest::setExpectedException() * PHPOffice#382 : PHPCS Fixes * PHPOffice#382 : PHPDoc : PHP Fatal error: Uncaught Doctrine\Common\Annotations\AnnotationException * PHPOffice#540 : Disable documentation * PHPOffice#540 : Disable documentation * fix other image mime type * Drop the support for HHVM * Add support for image hyperlinks * Update CHANGELOD.md * Display hyperlink properties of Drawing\Gd shape
|
isSubScript and isSuperScript Always false when getting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I fixed a little bug : in a Font, when I set the subscript to false, the superscript is automatically set to true. And, when I set the superscript is the opposite.
I also modified the test case to test this toggle for subscript and superscript.
Good Job!
Bye