New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "Show Type" presentation prop #588
Conversation
Allows for setting “Show Type” (presented by a speaker, browsed by an individual or browsed at a kiosk) for PowerPoint2007.
Simple fix, start index was messed up. Also changed nonsensical pre-increment to post-increment.
@@ -757,6 +828,7 @@ protected function writeSlideAnimations(XMLWriter $objWriter, Slide $oSlide) | |||
*/ | |||
protected function writeShapeDrawing(XMLWriter $objWriter, ShapeDrawing\AbstractDrawingAdapter $shape, $shapeId) | |||
{ | |||
exit( 'eyah'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Progi1984 The reason I had this debug message here, is because I noticed that this function, writeShapeDrawing
is never called anywhere. Would it be a good idea to remove it entirely?
Thanks, I will fix that debug msg, and will supply a unit test to get 100% code coverage. ASAP... |
@zmip Could you think you can rebase your PR to new modifications or can I use your code ? |
Great! I'm deeply ashamed I made you wait this long to fix this myself. And now you did it. So thanks @Progi1984! |
Bonus : the documentation is up to date 😉 |
Allows for setting “Show Type” (presented by a speaker, browsed by an
individual or browsed at a kiosk) for PowerPoint2007.