allow to override TemplateProcessor#ensureUtf8Encoded #1430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the method is
protected
,but since it is called with
self
instead ofstatic
it does not allow for subclasses to override it
(we have a special case of mostly ISO-8859-1 strings sometimes containing MS Word apostrophes,
and these appear as question marks in the document when
utf8_encode
is used,but are displayed fine when we use
mb_convert_encoding($string, 'UTF-8', 'windows-1252')
)An alternative would be to make the
ensureUtf8Encoded
non static,since it only appears to be used in a non static method.