TrackChange doesn't handle all return types of \DateTime::createFromFormat(...) #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DateTime::createFromFormat(...) returns either a \DateTime instance or FALSE, not NULL. Working on the basis that there might be legitimate TrackChange constructor calls containing a NULL date parameter, line 67 has been expanded to check not only for NOT NULL but also NOT FALSE. Without this additional check, a document with "Track Changes" enabled could cause an Exception to be raised when loaded into a reader. "Exception: DateTime::__construct(): Failed to parse time string (@) at position 0 (@): Unexpected character"
mikehudson
pushed a commit
to mikehudson/PHPWord
that referenced
this pull request
Apr 16, 2019
…ormat(...) (PHPOffice#1584) * Added boolean check before setting the date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DateTime::createFromFormat(...) returns either a \DateTime instance or FALSE, not NULL. Working on the basis that there might be legitimate TrackChange constructor calls containing a NULL date parameter, line 67 has been expanded to check not only for NOT NULL but also NOT FALSE.
Without this additional check, a document with "Track Changes" enabled could cause an Exception to be raised when loaded into a reader.
"Exception: DateTime::__construct(): Failed to parse time string (@) at position 0 (@): Unexpected character"
I couldn't see any relevant documentation that would benefit from being updated with details of this change, hence the incomplete checklist.
Fixes # N/A
Checklist:
composer run-script check --timeout=0and no errors were reported