Add Option for Dynamic Chart Legend Position #1699 #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Writer/Part/chart.php - Add dynamic Legend positions The position of the legend of charts was always fixed to the right. Adding in the option to set it dynamically via a new option under styles/chart * Update Styles/Chart.php Add in the public functions to getStyle() to get and set the legend position
* Writer/Part/Chart.php Add dynamic Legend positions The position of the legend of charts was always fixed to the right. Adding in the option to set it dynamically via a new option under styles/chart * Update Syle/Chart.php Add in the public functions to getStyle() to get and set the legend position
Add Option for Dynamic Chart Legend Position
jet-desk
reviewed
May 5, 2021
| protected static function parseHorizRule($node, $element) | ||
| { | ||
| $styles = self::parseInlineStyle($node); | ||
|
|
||
| // <hr> is implemented as an empty paragraph - extending 100% inside the section | ||
| // Some properties may be controlled, e.g. <hr style="border-bottom: 3px #DDDDDD solid; margin-bottom: 0;"> | ||
|
|
||
| $fontStyle = $styles + ['size' => 3]; | ||
| $fontStyle = $styles + array('size' => 3); |
There was a problem hiding this comment.
why you changed [] => array() ???
There was a problem hiding this comment.
https://github.com/PHPOffice/PHPWord/blob/develop/src/PhpWord/Shared/Html.php
To keep the same code style. Other code of 'Html.php' file use 'array()' instead of '[]' too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently thechart legend position cannot be altered via an option. This release fixes that by adding in an option in getStyle to set the legend position. It's using the ISO standards for adding it.
(#1699)
Checklist:
composer run-script check --timeout=0and no errors were reported