Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Image relative and absolute positioning #217

Closed
wants to merge 5 commits into from
Closed

Added Image relative and absolute positioning #217

wants to merge 5 commits into from

Conversation

basjan
Copy link
Contributor

@basjan basjan commented May 3, 2014

@ivanlanin and others: This is my first pull request.

I have added a small part of my amendments to the code, which @gabrielbull published under issue #209
The changes relate the absolute and relative positioning of images.

Would this be what you would expect from me ?

Regards

@ivanlanin ivanlanin self-assigned this May 3, 2014
@ivanlanin
Copy link
Contributor

Thanks @basjan. Yes, this is what we expected. Great enhancements.

Your pull failed Travis build because PHPWord uses PSR coding standards. But don't worry. This can be fixed easily. I'll review and merge your pull this weekend.

Whenever you have time, please read our contributing guideline. Thanks again for your contribution. Welcome to GitHub :)

@basjan
Copy link
Contributor Author

basjan commented May 3, 2014

@ivanlanin Thank you very much. I am learning a lot new these few days.

I have installed Eclipse as IDE with a PHP_Codesniffer plugin. However, it seems that somekind of ruleset needs to be used.

Do you have any idea?

@ivanlanin
Copy link
Contributor

I don't use Eclipse, but based on the screenshot I see from point number 2 on this page, you should check PSR-2 as your CodeSniffer standard.

@basjan
Copy link
Contributor Author

basjan commented May 3, 2014

I could reproduce the Travis CI errors and have now setup Eclipse, such that the code is checked on PSR-2 standard. Thanks

Bas-Jan 't Jong added 3 commits May 4, 2014 10:16
header in a section. This resulted in a corrupt DOCX
to the first header element. This resulted in a corrupted DOCX, when a
media element was assigned to a second header in the same section.
@basjan
Copy link
Contributor Author

basjan commented May 4, 2014

Sorry @ivanlanin , it seems I am messing things up.
I had created a new branch to fix a header bug, but when I created a pull request, it showed 280 files changed. I think that when creating a new branch, I should first update from Github or so ?

I changed the bug in my 'develop' branch and committed this, but this is then apparently added to the already pending pull request.

Again sorry for the mess up, and thanks for all the help you already provided.

@ivanlanin
Copy link
Contributor

No problem. This page may help you to sync your fork.

@ivanlanin
Copy link
Contributor

Hi @basjan. I've merged your code to the develop branch with some refactoring. If you have time, can you please add some samples on Sample_13_Images.php? Thanks.

@ivanlanin ivanlanin closed this May 4, 2014
@ivanlanin ivanlanin added this to the 0.11.0 milestone May 5, 2014
This was referenced May 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants