Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elements to PHPWord object via html #231

Merged
merged 2 commits into from
May 10, 2014
Merged

Conversation

basjan
Copy link
Contributor

@basjan basjan commented May 10, 2014

Here is my proposal for the function to add elements to a PHPWord object, for example a Section or a TextBox.
I decided to write it as a static function set similar to the conversion functions like 'emuToPixels', because these functions also convert a HTML snippet to an object subtree, which is inserted into the PHPWord object.

@ivanlanin
Copy link
Contributor

Wow. You're fast :) I'll review and merge your code tonight or early tomorrow. Thanks.

@ivanlanin ivanlanin self-assigned this May 10, 2014
@basjan
Copy link
Contributor Author

basjan commented May 10, 2014

@ivanlanin was already writing a few days :) (Actually evenings)

@ivanlanin ivanlanin added this to the 0.11.0 milestone May 10, 2014
ivanlanin added a commit to ivanlanin/PHPWord that referenced this pull request May 10, 2014
@ivanlanin ivanlanin merged commit 07b4ae2 into PHPOffice:develop May 10, 2014
@ivanlanin
Copy link
Contributor

Merged. I moved addTable to AbstractContainer to avoid duplication.

@ivanlanin
Copy link
Contributor

Don't forget to sync. Your local fork seems not updated.

@basjan basjan deleted the AddHtml branch May 10, 2014 18:11
@Progi1984 Progi1984 added the Pull label May 11, 2014
@basjan basjan mentioned this pull request May 29, 2014
@basjan
Copy link
Contributor Author

basjan commented May 29, 2014

Sorry @ivanlanin but not in the near future.
I now have contributed (with #253) all elements I need for my main project, so I will mainly continue with that.
When I have some spare time, I will focus on the ODF writer, to make sure that all is implemented and maybe even on the PDF writer (I like the concept of this project very much to be able to define a document without being restricted to the type of output)

@ivanlanin
Copy link
Contributor

No problem. Thanks for you contributions. Success with your project. Please check out the latest develop branch whenever you have time to start developing PHPWord again.

@basjan
Copy link
Contributor Author

basjan commented May 29, 2014

I will certainly keep track on the developments on this project. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants