Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Field element #251

Merged
merged 7 commits into from
May 29, 2014
Merged

Added Field element #251

merged 7 commits into from
May 29, 2014

Conversation

basjan
Copy link
Contributor

@basjan basjan commented May 28, 2014

Following issue #209 I have added Field functionality. As there are numerous fields with numerous properties and options, I have designed the possibility to add these into the $fieldsArray in src/PhpWord/Element/Field.php
Currently I only have added a DATE, PAGE and NUMPAGES field, but if someone has the time, one can easily add additional fields.

@ivanlanin ivanlanin self-assigned this May 29, 2014
@ivanlanin ivanlanin added this to the 0.11.0 milestone May 29, 2014
@ivanlanin
Copy link
Contributor

Thanks @basjan. I'll merge this pull ASAP.

@ivanlanin ivanlanin merged commit 8f74f26 into PHPOffice:develop May 29, 2014
@basjan
Copy link
Contributor Author

basjan commented May 29, 2014

Thanks @ivanlanin . I see it still takes some of your time, when I submit a pull request. I will try for my next pull request to reduce that time.

@basjan basjan deleted the Field-element branch May 29, 2014 09:31
@ivanlanin
Copy link
Contributor

We thank you. You can help by adding your changes into the changelog and updating the relevant documentation. But don't worry too much about that. We can always update them later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants