Commits on Apr 2, 2024

1. [BUGFIX] Remove invalid tool call from composer check script …

   With commit [1] development dependencies have been removed
   from the `composer.json`, but not from the `composer.lock`.
   
   This indicates a inproper use of `composer` and should be
   taken care in review of pull-requests. A good practice here
   is to etablish a rule that composer commands needs to be
   added to the commit message and the pull-request.
   
   Other removed dependency and downgraded dependencies have
   been fixed or readded meanwhile, still missing the `phpcs`
   tool for the `check composer script`.
   
   The `CONTRIBUTION.md` states to execute `composer check`
   before creating a pull-request, which is literally broken
   due to the missing dependency.
   
   This change removes the php sniffer call from the check
   script. Additionally, the composer scripts are enhanced
   to use the same php binary used to invoke composer itself
   to mitigate issues using the wrong php version on systems
   with multiple php version binaries.
   
   Further consideration should be to use the check command in
   the Github Action workflow to have a border if development
   toolchain is gonna be broken with a change.
   
   [1] PHPOffice@c3e34a0

   

   sbuerk committed Apr 2, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 1dab8ee
   • Browse repository at this point

   Copy the full SHA

   1dab8ee View commit details

   Browse the repository at this point in the history