Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error: Call to a member function getHashCode() on null #1872

Closed
ivanstan opened this issue Feb 22, 2021 · 1 comment
Closed

Error: Call to a member function getHashCode() on null #1872

ivanstan opened this issue Feb 22, 2021 · 1 comment

Comments

@ivanstan
Copy link
Contributor

ivanstan commented Feb 22, 2021 •
edited

Got error

Error: Call to a member function getHashCode() on null

In following code there is no check if $definedName->getWorksheet() returns null

PhpSpreadsheet/src/PhpSpreadsheet/ReferenceHelper.php

Line 611 in 1318b90

if ($definedName->getWorksheet()->getHashCode() === $pSheet->getHashCode()) {

while in definition of the method getWorksheet, null is listed as a possible outcome.

PhpSpreadsheet/src/PhpSpreadsheet/DefinedName.php

Line 162 in 1318b90

public function getWorksheet(): ?Worksheet

@ivanstan ivanstan mentioned this issue Feb 22, 2021
Merged
5 tasks
@MarkBaker
Copy link
Member

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MarkBaker @ivanstan