Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class BaseDrawing imageIndex Should provide modification methods #2323

Closed
luoyangpeng opened this issue Oct 7, 2021 · 1 comment · Fixed by #2416
Closed

Class BaseDrawing imageIndex Should provide modification methods #2323

luoyangpeng opened this issue Oct 7, 2021 · 1 comment · Fixed by #2416

Comments

@luoyangpeng
Copy link

luoyangpeng commented Oct 7, 2021

This is:

- [ ] a optimization suggestion
- [ ] a feature request
- [ ] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)

What is the expected behavior?

Class BaseDrawing add function setImageIndex method,Allow users to set image index.
For many identical pictures, set the imageIndex property,export efficiency can be greatly improved.

<?php
 public function setImageIndex($imageIndex)
 {
    $this->imageIndex = $imageIndex;
    return $this;
 }

What is the current behavior?

Currently, the number of pictures is counted as an index, and pictures are reused differently

<?php
 ++self::$imageCounter;
 $this->imageIndex = self::$imageCounter;
@MAKS-dev
Copy link

MAKS-dev commented Oct 7, 2021

Have look at #1153 (or the older #543).
Still hoping on a official fix for this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants