Psr16Adapter get item even if it is expired

[piernik]

Configuration:

PhpFastCache version: 6
PHP version: 7.0
Operating system: widnows 10

Issue description:

As in topic. I think that adapter's get method does not check expiration date. I think it should. I use files strategy

[Geolim4]

Hello,

What do you mean by:

I think that adapter's get method does not check expiration date

The file is tested:
https://github.com/PHPSocialNetwork/phpfastcache/blob/final/tests/Psr16Adapter.test.php#L1

And the tests are passing ?
https://travis-ci.org/PHPSocialNetwork/phpfastcache/jobs/307150874#L771

Cheers,
georges

[piernik]

I set new item with time to be valid set('key','value', 10);.
After 15 seconds I fetch it with get('key'). I get value instead of null as it should be invalid.

[Geolim4]

After the 15 seconds are you still in the same process ?

[piernik]

Yes - for tests I give sleep(15). But in Psrl6Adapter I see no $item->isExpired() call.
BTW: great class name ;)

[Geolim4]

You right, I'm storing the cache item in memory, this is maybe more a design issue more rather than a bug.
The psr-16 documentation is not really clear about it :/

BTW: great class name ;)

KISS principle :)

[Geolim4]

The next release is planned in a couple of weeks, if you can't wait until then you can use dev-master.

Cheers,
Georges