Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6] Fix composer package name should be all lowercase #671

Merged
merged 1 commit into from
Jan 31, 2019
Merged

[v6] Fix composer package name should be all lowercase #671

merged 1 commit into from
Jan 31, 2019

Conversation

jfcherng
Copy link
Contributor

Proposed changes

Composer 1.8.2 (latest) would now emit a deprecation warning that package name should in lowercase.

So I think it would be better to change the install command in the README.

Deprecation warning: require.phpFastCache/phpfastcache is invalid, it should not contain uppercase characters. 
Please use phpfastcache/phpfastcache instead. Make sure you fix this as Composer 2.0 will error.

Types of changes

What types of changes does your code introduce to Phpfastcache?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing code/behavior)
  • Deprecated third party dependency update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation/Typo/Resource update that does not involve any code modification

Agreement

I have read the CONTRIBUTING and CODING GUIDELINE docs

Deprecation warning: require.phpFastCache/phpfastcache is invalid,
it should not contain uppercase characters. Please use
phpfastcache/phpfastcache instead. Make sure you fix this
as Composer 2.0 will error.

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
@Geolim4 Geolim4 merged commit 8ddb502 into PHPSocialNetwork:v6 Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants