Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

Remove conflict with HHVM #15

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Conversation

sanmai
Copy link
Contributor

@sanmai sanmai commented Nov 14, 2020

GitHub Actions' VMs include HHVM even if you not using it (among many other things), therefore having a conflict with HHVM leads to a need to install a package with --ignore-platform-req=hhvm to test with it on GitHub because Composer considers HHVM even if you run Composer itself with plain old PHP. I would understand if it would consider HHVM if you would be using it with HHVM, but it isn't. (But on the other hand this makes sense since, IIRC, you can't run Composer with HHVM.)

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - php-cs-fixer/phpunit-constraint-xmlmatchesxsd v1.2.1 requires phpunitgoodpractices/polyfill ^1.4 -> satisfiable by phpunitgoodpractices/polyfill[v1.4.0].
    - php-cs-fixer/phpunit-constraint-xmlmatchesxsd v1.2.1 requires phpunitgoodpractices/polyfill ^1.4 -> satisfiable by phpunitgoodpractices/polyfill[v1.4.0].
    - phpunitgoodpractices/polyfill v1.4.0 conflicts with hhvm[99.999].
    - hhvm 99.999 conflicts with phpunitgoodpractices/polyfill[v1.4.0].
    - Installation request for hhvm 99.999 -> satisfiable by hhvm[99.999].
    - Installation request for php-cs-fixer/phpunit-constraint-xmlmatchesxsd ^1.2.1 -> satisfiable by php-cs-fixer/phpunit-constraint-xmlmatchesxsd[v1.2.1].

Which is all downright annoying. Who's actually using HHVM outside of Facebook these days?.. Even they are not.

@keradus
Copy link
Member

keradus commented Nov 16, 2020

Hey. thanks for the PR. I actually done it in plenty other repos already. good catch!

@keradus keradus merged commit 14a804c into PHPUnitGoodPractices:master Nov 16, 2020
@sanmai sanmai deleted the patch-1 branch November 16, 2020 22:49
sanmai added a commit to sanmai/polyfill that referenced this pull request Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants