Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PHP version (5.4) into require composer.json section and SQLite… #11

Closed
wants to merge 1 commit into from
Closed

Added PHP version (5.4) into require composer.json section and SQLite… #11

wants to merge 1 commit into from

Conversation

corpsee
Copy link
Contributor

@corpsee corpsee commented Jan 29, 2017

Added PHP version (5.4) into require composer.json section and SQLite into require-dev composer.json section

@dracony
Copy link
Member

dracony commented Jan 29, 2017

Hi @corpsee =)
The sqlite extensions is really not required, since you can still use the library with other drivers without it, even PDO is not required since yooou can still use the Mongo Driver. Maybe add them to required-dev instead or to suggests. I want to avoid the possibility of the library not installing just because a person doesn't have the extension they wouldn't use anyway.

@corpsee
Copy link
Contributor Author

corpsee commented Jan 29, 2017

Hi @dracony)
Ok, you know better about it. Suggests section would be good solution, I think.

@corpsee corpsee closed this Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants