Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Dependencies #45

Merged
merged 10 commits into from
May 9, 2024
Merged

Upgrade Dependencies #45

merged 10 commits into from
May 9, 2024

Conversation

lishaduck
Copy link
Member

@lishaduck lishaduck commented May 9, 2024

Description

This PR upgrades dependencies.

Closes: #41


Type of Change

  • ♻️ Code refactor
  • 🧹 Reduce tech debt
  • 🗑️ Chore

Checklist

Checklist

Edit tasklist title
Beta Give feedback Tasklist Checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Read the Contributing Guidelines.
    Options
  2. Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
    Options
  3. Fill out this template.
    Options
  4. Log your hours.
    Options
  5. Check that commits follow the Angular commit convention, more or less.
    Options
  6. Ideally, include relevant tests that fail without this PR but pass with it (if applicable).
    Options
Loading

Tested on

  • macOS 14

Bump preact.
Downgrade gfm to a csr compatible version.

HeadlessUI v2.0 is broken, and HeadlessUI v1.18 added code from v2.0.
It's mostly turned off, but it's still in the bundle.
It relies on process.env.JEST_WORKER_ID to disable some features.
We use combobox, the affected component, so we can't upgrade.
I disabled some rules:
useDefaultSwitchClause doesn't have type information.
It found a real bug in compile-mdx.
Luckily, JS was lenient enough it didn't make a big deal.
@lishaduck lishaduck added the enhancement New feature or request label May 9, 2024
@lishaduck lishaduck self-assigned this May 9, 2024
I gave up on streaming for now, but this is still a nice simplification.
@lishaduck lishaduck marked this pull request as ready for review May 9, 2024 15:25
@lishaduck lishaduck requested review from MattsAttack, iiAzui and a team as code owners May 9, 2024 15:25
@lishaduck lishaduck merged commit 2407bee into next May 9, 2024
1 check passed
@lishaduck lishaduck deleted the up branch May 9, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant