Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the max number of records read by kef2ph5 #370

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nick-falco
Copy link
Collaborator

kef2ph5 would fail if a file contained more than 10,000 records.

What does this PR do?

Increase the number of records that keftoph5 reads.

Checklist

  • This PR is not directly related to an existing issue (which has no PR yet).
  • All tests pass.
  • Any new or changed features have are documented.
  • Changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .

@nick-falco nick-falco added the bug label Nov 15, 2019
@nick-falco nick-falco self-assigned this Nov 15, 2019
Copy link
Contributor

@dsentinel dsentinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the failure mode? Have you hit this?
It's in a while True loop, so It shouldn't be limited, but only works on 10,000 at a time

@nick-falco
Copy link
Collaborator Author

I can send you an example kef file that breaks this if you'd like? I was running into problems when trying to read very large kef files. Increasing the number of records read in each iteration of the loop fixed the issue, likely because it read them all on the first iteration. Please view this as a WIP. I think I need to take another look at this.

@nick-falco nick-falco added the WIP Work in progress label Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants