Make config for Kouka the same as JJ Dossen; add new "dev" config #28
Conversation
| @@ -1,38 +1,4 @@ | |||
| { | |||
|
|
|||
There was a problem hiding this comment.
I moved all these out of "pih-config-liberia-harper-jjdossen" and into "pih-config-harper"... both JJ Dossen and Kouka use the "pih-config-harper" so they will now have the exact same components enabled.
I also removed "MCH" from the list so that it won't be enabled.
There was a problem hiding this comment.
Maybe @BranfordTGbieor wants MCH on Kouka for development?
There was a problem hiding this comment.
Thanks @lnball, but I'm not sure we would need that for now. I suggested the dev of the forms reach a particular stage before we enable them on kouka for testings purposes. Maybe in the next two weeks or so...
| @@ -6,39 +6,35 @@ | |||
| "site": "HARPER", | |||
|
|
|||
There was a problem hiding this comment.
This is just the diff that results from replacing the "components" here with those defined in "pih-config-liberia-harper-jjdossen.json"
| @@ -0,0 +1,39 @@ | |||
| { | |||
There was a problem hiding this comment.
This is a new development configuration I set up that we can use on our development laptops. It has the exact same components as the "pih-config-liberia-harper", but also has MCH enabled so we can work on developing and testing that.
To use this, in your runtime properties you'd basically just set:
pih.config=liberia,liberia-harper,liberia-harper-dev
The components defined in "liberia-harper" would be overridden with the ones defined here.
There was a problem hiding this comment.
OK, that's good! That way we get the flexibility of not manually changing configs between environments. Is that correct @mogoodrich ?
There was a problem hiding this comment.
@BranfordTGbieor it allows you to have a configuration setting you can use for development (of the MCH forms right now) which is different than what is on Kouka, so we can have Kouka show exactly what will go out to JJ Dossen.
|
Except for the one question about MCH on kouka, it looks good. |
|
Thanks @lnball ... yeah, we were discussing that yesteday... my thought was prior to the release we make Kouka and JJ Dossen identical so we know exactly what is going out to JJ Dossen when testing. Longer term, it might make sense to have both a staging server and a demo server (so in this case the staging server would have MCH turned on, but the demo server would not). |
|
Merged this this, thanks Ellen and Branford. |
No description provided.