Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lib xxx mh epilepsy form updates #92

Closed
wants to merge 4 commits into from

Conversation

tommyiversonj
Copy link
Contributor

@lnball I wanted to inform you that I made some changes to the epilepsy medication section by replacing drug concepts with drugs two days ago. I created a pull request for review, but I forgot to update the ticket. Unfortunately, my request was not reviewed, and your latest changes were pulled without my modifications. I tried to clean up my code and closed the pull request.

However, while testing the form, I noticed that certain concepts (CIEL:156661, CIEL:1625, CIEL:159499, PIH:14678, PIH:14680, CIEL:120252, PIH:14679) could not be found in your recent updates and were loaded with errors. I attempted to resolve this issue by generating and downloading a new MDS package for the new concepts, but the errors persisted. I tested Kouka and found that it worked perfectly, but unfortunately, it did not work in my dev environment. As a result, I decided to comment on the code so that I could continue testing other parts of the form.

I hope this did not cause any issues with your work. Yesterday, my internet connection was unstable, and that's why I didn't notify you earlier. Let me know if you need any further assistance. The medication section looks good, we will work with it. Thanks

@lnball
Copy link
Member

lnball commented May 10, 2023

Those concepts should be in the mental health mds (pihemr config):
image

@lnball
Copy link
Member

lnball commented May 11, 2023

@tommyiversonj I think this can be closed. Reviewed all the changes. Some of the changes in this pull request will updo the updates I made. Maybe you commented them out to work on your SDK. We should get your SDK working tomorrow. Sorry Engineer.

@tommyiversonj tommyiversonj deleted the LIB-XXX-MH-epilepsy-form-updates branch May 12, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants