New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multicore support #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
early review: multithreading is working really well impressive job! on my PC now it is something like x10 faster.
There are still some problems: some await are missing in pivx_shielding.js and on MPW spent notes are not removed from the list leading to errors
be7e70d
to
ae28c75
Compare
can you rebase this on master? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 603f959
heavily tested:
On firefox this with 31 spent notes took less than 3 minutes
https://testnet.rockdev.org/tx/b580f57f19a356ae27c23718933667c47a8d340f957d12ab2d61c81bd4d95638
On chromium this with 31 spent notes took about 5 minutes
https://testnet.rockdev.org/tx/0249e53e723306b11a57bf3150ec18943296891391c1d7afa2ca095c63d0e9be
Only one problem: note spent ONLY IN s->t shield transaction are not removed right after the tx is confirmed (in s->s everything works fine) but we can fix it in another PR
Update: looks like it is not working only on big shield tx
Just a comment: Stable Safari does not support this because of this bug: https://bugs.webkit.org/show_bug.cgi?id=25212, which has already been fixed at least since November 2022 on Technology Preview |
Adds multicore support. The feature will only be enabled if the browser supports it.
To build with multicore, run the script
./build_multicore.sh
.To build without,
wasm-pack --target web
.Both should be built to make sure the browser can fetch the one it needs.
On MPW side, the following headers should be set on the dev server:
Closes #27