Make ShieldData self contained #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duddino
requested changes
Nov 3, 2023
js/pivx_shield.js
Outdated
| this.isTestNet, | ||
| ); | ||
| if (address != shieldData.defaultAddress) { | ||
| load(shieldData) { |
There was a problem hiding this comment.
I would make load static and make it return a PIVXShield instance instead of adding other things to the create function
|
done |
Duddino
requested changes
Nov 3, 2023
js/pivx_shield.js
Outdated
Comment on lines
207
to
209
| * Creates a PIVXShield object from a ShieldData | ||
| * @param {ShieldData} shieldData - shield data | ||
| */ |
There was a problem hiding this comment.
Suggested change
| * Creates a PIVXShield object from a ShieldData | |
| * @param {ShieldData} shieldData - shield data | |
| */ | |
| * Creates a PIVXShield object from a ShieldData | |
| * @param {string} shieldData - shield data | |
| */ |
Change this to string and add JSON.parse inside the function. We are not making shieldData transparent to the user, so I would avoid passing the object directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
save and load the extended full viewing key in place of a useless default address in this way:
ShieldDatais self contained and we can create a full view instance only from itsaveandloadare no longer asyncShieldDataandextfvk