Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][GUI] Add/Edit Label button isn't showing as expected #1617

Closed
ambassador000 opened this issue May 11, 2020 · 2 comments
Closed

[Bug][GUI] Add/Edit Label button isn't showing as expected #1617

ambassador000 opened this issue May 11, 2020 · 2 comments
Labels
Good First Issue issues suited for new contributors

Comments

@ambassador000
Copy link

  1. Start wallet from scratch
  2. Go to Receive tab
  3. Assuming Receiving address that got showed up first had no label, button would be Add Label
  4. When you click on a Receiving address that is already labeled, button will change to Edit Label, and when you select again an address without label, button will stay Edit Label instead of Add Label.

addLabelBug1
@furszy furszy added the Good First Issue issues suited for new contributors label May 11, 2020
@ambassador000
Copy link
Author

Issue is also in the following case:
(unlock the wallet for easier reproduction)

  1. In Receive tab, click Generate Address, new address will be created
  2. Now click again Generate Address, new address will be created, but button will remain Edit Label, although freshly generated address does not have any label yet

Tried with 5.0.0

furszy referenced this issue in furszy/bitcoin-core Jan 10, 2021
@furszy
[GUI] Receive screen, fix missing "Add label" text.
fdcceb6 
Fixing bitcoin#1617
@furszy furszy mentioned this issue Jan 10, 2021
Merged
furszy added a commit that referenced this issue Jan 12, 2021
@furszy
Merge #2128: [GUI] Receive screen, fix missing "Add label" text.
5c46122 
fdcceb6 [GUI] Receive screen, fix missing "Add label" text. (furszy)

Pull request description:

  Fixing #1617

ACKs for top commit:
  random-zebra:
    utACK fdcceb6
  Fuzzbawls:
    ACK fdcceb6

Tree-SHA512: cbf83d6bcd151c24c216a5791f03ec98eedc1b465e3581db409dc4d3102c766c86e18dd0c0e7b8f43672e473d2728f8cfe42ac52c916ded3ca6b2f60efea6c3d
@furszy
Copy link

furszy commented Jan 12, 2021

solved on #2128, closing.

@furszy furszy closed this as completed Jan 12, 2021
Fuzzbawls pushed a commit to Fuzzbawls/PIVX that referenced this issue Jan 14, 2021
@furszy @Fuzzbawls
[GUI] Receive screen, fix missing "Add label" text.
ed1d377 
Fixing PIVX-Project#1617

Github-Pull: PIVX-Project#2128
Rebased-From: fdcceb6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue issues suited for new contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@furszy @ambassador000