Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GUI][Trivial] Unselected Custom shows lower fee than possibly accepted #1621

Closed
ambassador000 opened this issue May 12, 2020 · 1 comment
Closed

[GUI][Trivial] Unselected Custom shows lower fee than possibly accepted #1621

ambassador000 opened this issue May 12, 2020 · 1 comment

Comments

@ambassador000
Copy link

When Recommended is selected in Customize Fee dialog, Custom below shows 0.000001, but when you select Custom fee as an option, it immediately shows your last saved Custom Fee.
Problem: unselected Custom below should show 0.0001, because that is the lowest possible fee that can be saved.

customFee1
ambassador000 added a commit to ambassador000/PIVX that referenced this issue May 12, 2020
@ambassador000
Change Custom fee amount when Recommended fee is selected
1b41d23 
Fix for issue PIVX-Project#1621
@ambassador000 ambassador000 mentioned this issue May 12, 2020
Merged
@random-zebra
Copy link

Technically, the value of 0.0001 PIV/kB for CWallet::minTxFee is only a default. It can be overridden with a startup flag (-mintxfee=<amt>), so maybe that could be used as placeholder.

random-zebra added a commit that referenced this issue Jul 1, 2020
@random-zebra
Merge #1623: [GUI][Trivial] Change Custom fee amount when Recommended…
b7e2d97 
… fee is selected

1b41d23 Change Custom fee amount when Recommended fee is selected (Ambassador)

Pull request description:

  Fix for issue #1621

ACKs for top commit:
  random-zebra:
    utACK 1b41d23
  furszy:
    utACK 1b41d23

Tree-SHA512: 75c3ad1122ee5b1d3d5eed62f3bc63184efaf3831b51e0a22127bbfe9952cd3e3ddf6952007853c145637d6f65e744ba7ceec75e592bbc3b46b66cec3f726b35
@furszy furszy closed this as completed Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@furszy @random-zebra @ambassador000