Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GUI][Trivial] Box outside of the PIVX address stays red when it's empty #1639

Closed
ambassador000 opened this issue May 22, 2020 · 1 comment
Closed

[GUI][Trivial] Box outside of the PIVX address stays red when it's empty #1639

ambassador000 opened this issue May 22, 2020 · 1 comment
Milestone
5.1.0

Comments

@ambassador000
Copy link

ambassador000 commented May 22, 2020 •
edited
Loading

Pretty useless, but this opened issue is only to achieve perfectionism.

Working scenario:
Go to Send tab -> click on the arrow next to the Address book icon -> click on any address with label -> now delete the Address label field and then delete the PIVX address field. Everything will be fine (Outside of the box will be white/grey color).

Non-working scenario:
Go to Send tab -> click on the arrow next to the Address book icon -> click on any address with label -> now type any character in PIVX address field (outside box will become red) -> delete the Address label field and delete the PIVX address field. Outside box will stay red, although it is empty and Send PIV button wasn't clicked.

sendBug1
@PicklesRcool PicklesRcool mentioned this issue Mar 15, 2021
Merged
random-zebra added a commit that referenced this issue Mar 15, 2021
@random-zebra
Merge #2249: [Qt] Make box of PIVX Send address return to purple when…
586a020 
… it's empty

a6a4af1 Make box of PIVX address return to purple when it's empty (Volodia)

Pull request description:

  This PR makes the box of the PIVX address in the send widget turn back to purple when previously filled and made empty.

  Issue: #1639

  Before fix:
  ![issue_1639_before](https://user-images.githubusercontent.com/36901185/111166098-717dc580-85a8-11eb-91d1-6c41a88fba88.gif)

  After fix:
  ![issue_1639_after](https://user-images.githubusercontent.com/36901185/111166124-7a6e9700-85a8-11eb-8382-f04311413224.gif)

ACKs for top commit:
  furszy:
    code wise looking good, utACK a6a4af1
  random-zebra:
    Nice little fix. Thanks, and welcome to the contributors list :) utACK a6a4af1 and merging...

Tree-SHA512: 6181eaff5d7605d76636b39934c064492d7ba0c99f27796e0e123383a29912f1b01b84314c37cd5e6d6f89cd33366da49807869e771c7a18c274b7fdf540eafa
@random-zebra random-zebra added this to the 5.1.0 milestone Mar 15, 2021
@random-zebra
Copy link

Closed in #2249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.0
Development

No branches or pull requests
2 participants
@random-zebra @ambassador000