[Consensus] Block version 7: remove accumulators checkpoint #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
added
Needs Release Notes
furszy
reviewed
Sep 23, 2019
furszy
previously approved these changes
Sep 27, 2019
Fuzzbawls
previously approved these changes
Sep 27, 2019
Warrows
reviewed
Oct 27, 2019
random-zebra
force-pushed
the
2019_block_version_7
branch
from
83a3736
to
dce9b67
Compare
|
Fixed |
|
Code wise, it's straightforward and looks good. Just need a rebase. |
random-zebra
force-pushed
the
2019_block_version_7
branch
from
dce9b67
to
81e25d9
Compare
|
Rebased. |
random-zebra
force-pushed
the
2019_block_version_7
branch
from
81e25d9
to
7143006
Compare
furszy
approved these changes
Nov 23, 2019
random-zebra
added a commit
that referenced
this pull request
Nov 23, 2019
7143006 [Trivial] Check for pindex != nullptr during loops (random-zebra) cef5a0e [PoS] Don't look for checkpoints after nBlockLastAccumulatorCheckpoint (random-zebra) d55e714 [Core] set nBlockLastAccumulatorCheckpoint in chainparams (random-zebra) 9cf6c69 [Core] define Block version 7 removing the accumulator checkpoints (random-zebra) 750d04f [Core] Set placeholders for nBlockV7StartHeight hardfork (random-zebra) Pull request description: Since the disabling of zerocoin mints, the accumulator values never change anymore. Last updated checkpoint was at mainnet block 1686240. Removing the accumulator checkpoints from block headers saves 256 bits per block (both on chain and on the in-memory indexes). This PR removes the need for CBlockIndex::nAccumulatorCheckpoint (past 1686240) and enforces block version 7 via hard-fork (after `nBlockV7StartHeight` currently set at a placeholder value). Further changes to CBlockIndex (in order to don't store empty uint256) will be addressed in a subsequent PR. ACKs for top commit: furszy: Good work on this first step 👍, ACK 7143006 Fuzzbawls: ACK 7143006 Tree-SHA512: 3d8944b86ffb0c5e968a875977610ee44093f7f22a473450e8ce48358e1e9907b07034d698f833cc13abea2aa9409d6c96a5f4e9e15f677eaf5dafa62418ff6a
Fuzzbawls
removed
the
Needs Release Notes
random-zebra
added a commit
to random-zebra/blockbook
that referenced
this pull request
Dec 27, 2019
martinboehm
pushed a commit
to trezor/blockbook
that referenced
this pull request
Jan 3, 2020
* PIVX: bump to 4.0.0 * PIVX: remove AccCheckpoint in block version 7 ref PIVX-Project/PIVX#1022 * PIVX: Test block v7 in pivxparser_test
bidoudan
pushed a commit
to stibits-inc/blockbook
that referenced
this pull request
Jul 4, 2022
* PIVX: bump to 4.0.0 * PIVX: remove AccCheckpoint in block version 7 ref PIVX-Project/PIVX#1022 * PIVX: Test block v7 in pivxparser_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the disabling of zerocoin mints, the accumulator values never change anymore.
Last updated checkpoint was at mainnet block 1686240.
Removing the accumulator checkpoints from block headers saves 256 bits per block (both on chain and on the in-memory indexes).
This PR removes the need for CBlockIndex::nAccumulatorCheckpoint (past 1686240) and enforces block version 7 via hard-fork (after
nBlockV7StartHeightcurrently set at a placeholder value).Further changes to CBlockIndex (in order to don't store empty uint256) will be addressed in a subsequent PR.