[GUI] Dashboard chart map first segfault, background task error catching. #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
changed the title
… when the first stake is received. Don't use the stake filter proxy which can or can't have stakes (always changing and being filtered).
furszy
changed the title
Fuzzbawls
approved these changes
Oct 2, 2019
furszy
added a commit
that referenced
this pull request
Oct 2, 2019
…k error catching. 38c654b [GUI] Dashboard hasStakes variable set when the view is loaded and/or when the first stake is received. Don't use the stake filter proxy which can or can't have stakes (always changing and being filtered). (furszy) 6f91049 [GUI] Background task catching errors that have no information about. (furszy) 72966c9 [GUI] Dashboard chart, covering edge empty list problem. (furszy) Pull request description: PR covering an empty list pointer segfault when the wallet has no stakes on the yearly filtered data when, for some reason, the chart got visible (when it shouldn't as there are no stakes..). It happened to me when was doing a reindex and the internal wallet state is not clear/final. Plus added a catch all in the background worker to not crash and inform to the user if there was an unexpected error running any UI background task. ACKs for top commit: random-zebra: ACK 38c654b Fuzzbawls: ACK 38c654b Tree-SHA512: b918700f9c97d78f131285b8b88dca28d9e9bb8a65dcd33e95d10e89f233d0ce0cc86b39f65794d836f487d2e119d5091aedb28a22bc3638417fd60421d98a88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR covering an empty list pointer segfault when the wallet has no stakes on the yearly filtered data when, for some reason, the chart got visible (when it shouldn't as there are no stakes..). It happened to me when was doing a reindex and the internal wallet state is not clear/final.
Plus added a catch all in the background worker to not crash and inform to the user if there was an unexpected error running any UI background task.