[Wallet][Refactor] Updating ancient getbalanceXXX methods to a lambda call. #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warrows
approved these changes
Oct 27, 2019
random-zebra
added a commit
that referenced
this pull request
Oct 27, 2019
…s to a lambda call. 7001b05 [Wallet][Refactor] Getbalance and similar methods lambda refactored. (furszy) Pull request description: Refactored and cleaned every `getBalanceXXX` method that was duplicating the same code over and over inside the wallet to a loop over txs lambda based function. ACKs for top commit: Warrows: ACK 7001b05 random-zebra: Very nice 👍 ACK 7001b05 Tree-SHA512: b43355b08a2a3c6118357f10076a57cbc8c21f83f3dfb86f0366eabdfe9d6706b9686d18593d74f3e5bfab0dff4936de6b12eaffbf2a13e438d3c0b8eb4019c2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored and cleaned every
getBalanceXXXmethod that was duplicating the same code over and over inside the wallet to a loop over txs lambda based function.