Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt] Fixup topbar balance calculation #1085

Merged
merged 1 commit into from Nov 24, 2019

Conversation

Fuzzbawls
Copy link
Collaborator

Prevents negative balance results

Before:
Screen Shot 2019-11-04 at 1 48 55 AM

After:
Screen Shot 2019-11-04 at 1 51 14 AM

@Fuzzbawls Fuzzbawls added the GUI label Nov 4, 2019
@Fuzzbawls Fuzzbawls added this to the 4.0.0 milestone Nov 4, 2019
@Fuzzbawls Fuzzbawls self-assigned this Nov 4, 2019
@Fuzzbawls Fuzzbawls requested a review from furszy November 4, 2019 09:52
@borris345
Copy link

Scaling issue there on the masternodes tab. Writing not shrink down with screen size? Or is mast...odes the new term 😝

@Fuzzbawls
Copy link
Collaborator Author

@borris345 that isn't really related to this particular PR...but an unrelated issue entirely...probably best to submit an issue report here on github (best), or hope it is remembered from comments here or elsewhere.

@furszy
Copy link

furszy commented Nov 4, 2019

That actually it is not inside the wallet @borris345 , surely a change in fuzzbawls sources. The code has a jump line there to show it properly and not with the dots.

src/qt/pivx/topbar.cpp Outdated Show resolved Hide resolved
Prevents negative balance results
@Fuzzbawls
Copy link
Collaborator Author

rebased and updated to use a simpler calculation per feedback

Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7caa366

Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7caa366.

furszy added a commit that referenced this pull request Nov 24, 2019
7caa366 [Qt] Fixup topbar balance calculation (Fuzzbawls)

Pull request description:

  Prevents negative balance results

  Before:
  ![Screen Shot 2019-11-04 at 1 48 55 AM](https://user-images.githubusercontent.com/7393257/68112047-56278400-fea5-11e9-9b86-0cc06fe18cc1.png)

  After:
  ![Screen Shot 2019-11-04 at 1 51 14 AM](https://user-images.githubusercontent.com/7393257/68112168-9edf3d00-fea5-11e9-9d8e-ab9174bf587b.png)

ACKs for top commit:
  random-zebra:
    ACK 7caa366
  furszy:
    ACK 7caa366.

Tree-SHA512: 3083d1eca47739ddf5d532a526b266e984894d95d19ac676d6924cac8ab6c99101aac8afc4f7c31414079a7aa55c549737aaf4002e3c1985f61217f44e8f5230
@furszy furszy merged commit 7caa366 into PIVX-Project:master Nov 24, 2019
@Fuzzbawls Fuzzbawls deleted the 2019_available-balance-fix branch January 9, 2020 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants