[GUI] Windowtitle parameter fix #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuzzbawls
approved these changes
Jan 19, 2020
|
I will add that this "feature" has no impact on the operational functionality of the underlaying application one way or another, thus have no problem with re-adding it. I can see the theoretical need/justification for someone customizing the main window's title. |
Fuzzbawls
added a commit
that referenced
this pull request
Jan 21, 2020
e0e8cdb [GUI] Windowtitle parameter fix (Mrs-X) Pull request description: This PR (re-) implements the windowtitle-parameter which got somehow lost during the wallet redesign. ACKs for top commit: Fuzzbawls: utACK e0e8cdb random-zebra: utACK e0e8cdb Tree-SHA512: 806d84479cedab41f31d3bcf761b91a8692aa257ab84fd7a8aa7ceb8ae1f5c10ee5bdaa35212b66150b853f3e4e35feee5461be0e61f41af49e0c10f3f1efa87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (re-) implements the windowtitle-parameter which got somehow lost during the wallet redesign.