Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Net] Do not launch the clock warning dialog like crazy. #1307

Merged

Conversation

furszy
Copy link

@furszy furszy commented Jan 25, 2020

Added a delay in the internal clock warning dialog launch to not end up creating dialogs like crazy, lagging the whole wallet.

A secondary thing that did was improve the text readability in the launched dialog.

@furszy furszy self-assigned this Jan 25, 2020
src/net.cpp Outdated Show resolved Hide resolved
@random-zebra random-zebra added this to the 4.1.0 milestone Jan 27, 2020
@furszy furszy force-pushed the 2020_fix_internal_clock_dialog branch from ed0f539 to df68739 Compare February 5, 2020 14:04
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK df68739

random-zebra added a commit that referenced this pull request Feb 6, 2020
df68739 [Net] Do not launch warning dialogs like crazy when the internal clock is not correct. (furszy)

Pull request description:

  Added a delay in the internal clock warning dialog launch to not end up creating dialogs like crazy, lagging the whole wallet.

  A secondary thing that did was improve the text readability in the launched dialog.

ACKs for top commit:
  random-zebra:
    utACK df68739

Tree-SHA512: 310873cccceb52f678cd463fdc2f9c3d198b9e31613fac8fd2312f79ba69f16303fd21b772f106217d05937bda9dc8a5bd3a01dd86fdce6ad80009c7597fab54
@random-zebra random-zebra merged commit df68739 into PIVX-Project:master Feb 6, 2020
@furszy furszy deleted the 2020_fix_internal_clock_dialog branch November 29, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants