[RPC][Tests] Don't throw when generate doesn't create all blocks (PoS) #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
force-pushed
the
2020_Tests_regtest-time
branch
from
927ce4d
to
1504db0
Compare
furszy
previously approved these changes
Feb 3, 2020
random-zebra
force-pushed
the
2020_Tests_regtest-time
branch
from
1504db0
to
2201662
Compare
furszy
previously approved these changes
Feb 4, 2020
UpdateTime is called only for PoW blocks, no need to check for TimeProtoV2
random-zebra
force-pushed
the
2020_Tests_regtest-time
branch
from
2201662
to
1eed11d
Compare
|
Rebased on master after #1299 merge. |
furszy
added a commit
that referenced
this pull request
Feb 12, 2020
…l blocks (PoS) 1eed11d [RPC] Don't throw in 'generate' when some PoS blocks cannot be created (random-zebra) ba1d930 [PoS] Skip prevblocktime check for regtest in 'Stake' (random-zebra) 9f614b7 [Core] Remove extra check in UpdateTime (random-zebra) Pull request description: Just return the list of hashes for the blocks generated. This affects only "live" usage of regtest wallet, as the functional tests use the utility function `generate_pos` which calls `generate(1)` and increases mocktime (or adds a `sleep`) when the node can actually stake but can't find a valid kernel at the current time. Top commit has no ACKs. Tree-SHA512: b921e16721eb4439bc04c1f5ffb0b9f587b82b2ebff23e05ad85fa88ce80a4ee2c5c9fca25119885e365ef417c8a0c06d7010d9841c9bb364a1e5d30bcd8e00f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just return the list of hashes for the blocks generated.
This affects only "live" usage of regtest wallet, as the functional tests use the utility function
generate_poswhich callsgenerate(1)and increases mocktime (or adds asleep) when the node can actually stake but can't find a valid kernel at the current time.