-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inlining sync.cpp with latest upstream, first step. #1335
Conversation
b39141e
to
de57678
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code ACK with a little question.
de57678
to
c453f8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK c453f8c
needs rebase |
1) Refactor: * Call sync.h primitives "locks" and "mutexes" instead of "blocks" and "waitable critical sections" to match current coding conventions and c++11 standard names. 2) Make LOCK, LOCK2, TRY_LOCK work with Mutex 3) WAIT_LOCK added.
c453f8c
to
cbe90ab
Compare
rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebase utACK cbe90ab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK cbe90ab
cfac9cf [Unittest] sync_tests backport. (furszy) f6ddf52 sync: Add RecursiveMutex type alias (furszy) 40a1004 Add debug_lockorder code (without unit test) (furszy) ab83d0d move-only: PASTE macros to util/macros.h (furszy) 25ebf51 Sync.h: AssertLockNotHeld backported. (furszy) Pull request description: This was done on top of #1335 (Starts on 7921802). Effort to bring us up-to-date with upstream's sync.h/cpp sources. The only task that left to be fully up-to-date with upstream, that will leave for a third PR because it touches other areas of the sources and want to keep this as small as possible, is the `CCriticalSection` removal and replacement with the `RecursiveMutex` typedef. ACKs for top commit: random-zebra: ACK cfac9cf Fuzzbawls: ACK cfac9cf Tree-SHA512: 1b6ed0e9be26232dd9b37a0629d9601f5f8967a523fa0d856542eef69c239fab8693980d925c012b5927447622fb601affa8fe6207360d58d7e61019800f33e2
7e493df Using WAIT_LOCK macro instead of WaitableLock. (furszy) a0d0e33 [Refactor] Complete move from CCriticalSection to identical RecursiveMutex (both are AnnotatedMixin<std::recursive_mutex>). (furszy) 6608757 doc: Add comment to cs_main and mempool::cs (furszy) Pull request description: This was done on top of #1335 and #1336 (Starting in bb575f8). Effort to bring us up up-to-date with upstream's sync.h/cpp sources. This PR contains: * A complete move from CCriticalSection to identical RecursiveMutex (both are AnnotatedMixin<std::recursive_mutex>). * Using WAIT_LOCK macro instead of WaitableLock. ACKs for top commit: random-zebra: utACK 7e493df Fuzzbawls: utACK 7e493df Tree-SHA512: 539fe93566f90246409606acb0aaeb3a5f839110cb96af7868654738685a07b9e1332f8362a04d328825291007d24c80d0b34b1318edc4afe84a8ac8e5affe61
Part of a group of updates that will be doing from upstream to get up-to-date with latest sync.h/cpp sources.
This first PR involves:
RenameThread
method calls where modified to use the newutil::ThreadRename
method).