Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Tor topbar icon status. #1339

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

furszy
Copy link

@furszy furszy commented Feb 17, 2020

Auto-descriptive title.

This PR adds Tor status in the topbar. (Possibly in the future, when we get lot more icons there, we should move it to another place as it's not an action and just a network status. But well, for now seems to be ok).

Thanks to rhubarbarian for the svg Tor icon 馃憣

@furszy furszy self-assigned this Feb 17, 2020
@random-zebra random-zebra added this to the 4.1.0 milestone Feb 17, 2020
Copy link

@Mrs-X Mrs-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 48ee1c4

BTW, those 'expanding' buttons are (depending on the device) a usability nightmare.
In a future PR I'll change them to have the text-info as normal bubble-help/tooltip.

Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 48ee1c4 and merging...

random-zebra added a commit that referenced this pull request Feb 18, 2020
48ee1c4 [GUI] Tor topbar icon status. (furszy)

Pull request description:

  Auto-descriptive title.

  This PR adds Tor status in the topbar. (Possibly in the future, when we get lot more icons there, we should move it to another place as it's not an action and just a network status. But well, for now seems to be ok).

  Thanks to rhubarbarian for the svg Tor icon 馃憣

ACKs for top commit:
  Mrs-X:
    ACK 48ee1c4
  random-zebra:
    ACK 48ee1c4 and merging...

Tree-SHA512: 5046ca55104e5c3086d5f335429a1741a16814aeb6ccc6019e9037290e85ed8b7d75159563fe665928810fbfe6390a8ae5b994475722064ed768dbfc3dd6246d
@random-zebra random-zebra merged commit 48ee1c4 into PIVX-Project:master Feb 18, 2020
@furszy furszy deleted the 2020_topbar_tor_info branch November 29, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants