Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] Bump minimum required Qt version to 5.5.1 #1351

Merged
merged 3 commits into from
Feb 24, 2020
Merged

[Build] Bump minimum required Qt version to 5.5.1 #1351

merged 3 commits into from
Feb 24, 2020

Conversation

Fuzzbawls
Copy link
Collaborator

As per #1292, this effectively bumps the minimum required Qt version to 5.5.1.

  • Removed no longer needed precompiler conditionals
  • Updated autotools to check for and require at least 5.5.1 to build the GUI
  • Updated CMake to check for and require at least 5.5.1 to build the pivx-qt target

Closes #1292

@Fuzzbawls Fuzzbawls added this to the 4.1.0 milestone Feb 23, 2020
@Fuzzbawls Fuzzbawls self-assigned this Feb 23, 2020
@Fuzzbawls Fuzzbawls added this to In Progress in perpetual updating PIVX Core to BTC Core via automation Feb 23, 2020
@Fuzzbawls Fuzzbawls mentioned this pull request Feb 24, 2020
Merged
1 task
random-zebra
random-zebra approved these changes Feb 24, 2020
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3f98b37

perpetual updating PIVX Core to BTC Core automation moved this from In Progress to Ready Feb 24, 2020
furszy
furszy approved these changes Feb 24, 2020
View reviewed changes
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, utACK 3f98b37

@furszy furszy merged commit 5ad9c81 into PIVX-Project:master Feb 24, 2020
perpetual updating PIVX Core to BTC Core automation moved this from Ready to Done Feb 24, 2020
@Fuzzbawls Fuzzbawls mentioned this pull request Feb 25, 2020
Merged
furszy added a commit that referenced this pull request Mar 3, 2020
@furszy
Merge #1358: [Build] Cleanup Qt m4 file
1517dbe 
9450439 build: remove extra tokens warning (Fuzzbawls)
ebb4da9 build: fix m4 escaping (Fuzzbawls)
2b3b9c3 doc: proper capitalize terms (Fuzzbawls)
efee3fc build: remove duplicated QT_STATICPLUGIN define (Fuzzbawls)

Pull request description:

  Further cleanups to the Qt m4 file that I wanted to keep separate from #1351

ACKs for top commit:
  random-zebra:
    ACK 9450439
  furszy:
    ACK 9450439

Tree-SHA512: 1d8c0194eb72116ea4ee414c31cec8a6f472c3493a0aa63e456188aff3a2c20b8871fba22b27947ebd303b0ebe42b86a2cbaed42d3ee424a69088d8e61070b34
random-zebra added a commit that referenced this pull request Mar 23, 2020
@random-zebra
Merge #1049: [Qt] Switch to newer connect syntax
521d13b 
c54fd9d [Qt] Switch to newer connect syntax (Fuzzbawls)

Pull request description:

  Switch all Qt connections to the newer functor-based syntax.

  Marked [WIP] for now until larger PRs can be merged.

  Mostly ported from bitcoin#13529

  Requires the following PR to be merged first in order to adhere to standards:
  - [x] #1351

ACKs for top commit:
  furszy:
    ACK c54fd9d
  random-zebra:
    ACK c54fd9d and merging...

Tree-SHA512: d5222264566a8920ab97e8c586f134156d9d0514d014b430bdd47a34b0620ab94a1c6d341b6a57322f1131a8fad91a5e1af907f3bd7112d0ab5e04c4cc9f5ae5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furszy furszy furszy approved these changes

@random-zebra random-zebra random-zebra approved these changes

Assignees

@Fuzzbawls Fuzzbawls

Labels
Build System
Projects
perpetual updating PIVX Core to BTC Core
  
Done
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

[RFC] Bump Minimum Qt Version to 5.5
3 participants
@Fuzzbawls @furszy @random-zebra