[Qt] Replace deprecated Qt methods #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`qSort`, `qStableSort`, `qLowerBound`, and `qUpperBound` have been marked as deprecated since Qt 5.2. Also, `QSslSocket::setDefaultCaCertificates()` and `QSslSocket::systemCaCertificates()` member functions are obsolete as of Qt 5.12 This PR replaces the former with their `std::` equivalents, and the latter with `QSslConfiguration` equivalents. Changes maintain backwards compatibility with Qt 5.5.1
furszy
approved these changes
Mar 2, 2020
random-zebra
added a commit
that referenced
this pull request
Jul 9, 2020
8231881 Use proper enum or nullptr for qFlags (Fuzzbawls) 1621ceb Replace more deprecated qt methods (Fuzzbawls) Pull request description: Follow up to #1357, this eliminates compiler warnings for Qt versions up-to and including 5.14. - qSort - screenGeometry - ByteSize - QSignalMapper - qFlags improper enum Also removes the unused old splashscreen files. Note: new compiler warnings about deprecation appear in Qt 5.15, but will need to handle them later as their replacement functions/suggestions aren't supported by Qt 5.9, which is our minimum supported version. ACKs for top commit: furszy: utACK 8231881 random-zebra: utACK 8231881 and merging... Tree-SHA512: 21941836d8406e5a9f73f1897d06137ff60495278cab90300da27c42c814ff82eaec5fe57364a60d06d742b35842b4e16739c098c5e66a7dd3f591ecf052f1fb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qSort,qStableSort,qLowerBound, andqUpperBoundhave beenmarked as deprecated since Qt 5.2.
Also,
QSslSocket::setDefaultCaCertificates()andQSslSocket::systemCaCertificates()member functions are obsolete as of Qt 5.12
This PR replaces the former with their
std::equivalents, and the latterwith
QSslConfigurationequivalents.Changes maintain backwards compatibility with Qt 5.5.1