[Chain][Bug] Fix mapZerocoinSupply recalculation #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
force-pushed
the
2020_zpiv_recalc
branch
from
ac725b0
to
d25bc02
Compare
random-zebra
force-pushed
the
2020_zpiv_recalc
branch
from
d25bc02
to
ecc6499
Compare
Fuzzbawls
approved these changes
Mar 1, 2020
furszy
approved these changes
Mar 2, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
df932b8 introduced a bug preventing resync on mainnet due to zerocoin supply recalculation missing.
ZPIV supply recalculation shouldn't be needed in the first place, if the client is syncing from scratch and correctly filtering invalid mints.
So, instead of restoring
RecalculateZPIVMinted/RecalculateZPIVSpent, this PR does 2 things:fixes
UpdateZPIVSupplyfiltering the invalid mints/spends since the start of zerocoin (not only afterZerocoin_Block_RecalculateAccumulators). So, syncing from scratch doesn not trigger any recalculation at the next startup.inserts a call to
UpdateZPIVSupplydirectly inRecalculatePIVSupply, to be used during init, e.g. by those clients updating from old versions (with wrong supply in the index), or when using-reindexmoneysupply.This removes the additional I/O operations that were originally required with
RecalculateZPIVMintedandRecalculateZPIVSpent(as blocks are already read insideRecalculatePIVSupply, and the relative indexes also already updated there).