Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Look at last CoinsView block for corruption fix process #146

Merged
merged 1 commit into from
Apr 26, 2017

Conversation

presstab
Copy link

This addresses #106

@presstab presstab changed the title Look at last CoinsView block for corruption fix process [WIP] Look at last CoinsView block for corruption fix process Apr 25, 2017
@jonspock
Copy link

utACK. This happened to me a couple of times. I will test with this code if it happens again

@Fuzzbawls
Copy link
Collaborator

Fuzzbawls commented Apr 26, 2017

ACK b826305

Though do note that the test was done on a pre-corrupted datadir. none of my own datadirs have shown any corruption.

@Fuzzbawls Fuzzbawls changed the title [WIP] Look at last CoinsView block for corruption fix process [Wallet] Look at last CoinsView block for corruption fix process [WIP] Apr 26, 2017
@presstab
Copy link
Author

Every instance users with #106 that I have given a binary built from this PR to has reported it worked.

@presstab presstab changed the title [Wallet] Look at last CoinsView block for corruption fix process [WIP] [Wallet] Look at last CoinsView block for corruption fix process Apr 26, 2017
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to rpcblockchain.cpp will need to be reverted or re-worked, otherwise this is solid.

@presstab
Copy link
Author

Temporary testing code got slipped in. Rebased and squashed.

@Fuzzbawls
Copy link
Collaborator

ACK f63c1a3

@presstab presstab merged commit f63c1a3 into PIVX-Project:master Apr 26, 2017
presstab added a commit that referenced this pull request Apr 26, 2017
…process

f63c1a3 Use the greater of last meta block and last CoinsView block for corruption fix process (presstab)

Tree-SHA512: 6dee1058c50df79f9761a5838aaa6e599c38a166a31989ac710cb904e43cb3561493585890ddb2b8e08771cde80284f812235ba9dc1be9c87e7b676ca9b1bafa
@Fuzzbawls Fuzzbawls moved this from In Progress to Completed in Resolve User Data Corruption Issues Apr 27, 2017
@Fuzzbawls Fuzzbawls modified the milestone: v2.2.1 Apr 27, 2017
Fuzzbawls pushed a commit to Fuzzbawls/PIVX that referenced this pull request Apr 27, 2017
Use the greater of last meta block and last CoinsView block for corruption fix process (presstab)

Github-Pull: PIVX-Project#146
Rebased-From: bce67cb
@presstab presstab deleted the block_corruption branch November 28, 2017 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants