Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] MacOS fix open files with no default app. #1516

Conversation

furszy
Copy link

@furszy furszy commented Apr 10, 2020

Built on top of #1515, only last commit counts for this.

When MacOS has no default app to open *.conf and *.log throws an error instead of try to open them with a text editor. This PR solves the issue.

Coming from btc@16044

@furszy furszy self-assigned this Apr 10, 2020
@random-zebra random-zebra added GUI macOS Issues/problems specifically related to macOS Upstream labels Apr 12, 2020
@random-zebra random-zebra added this to In Progress in perpetual updating PIVX Core to BTC Core via automation Apr 12, 2020
@random-zebra
Copy link

This can be rebased, now that #1515 is merged.

@random-zebra random-zebra modified the milestones: Future, 5.0.0 Apr 20, 2020
@furszy furszy force-pushed the 2020_macos_fix_open_files_with_no_default_app branch from db06bf0 to a41da9f Compare May 8, 2020 22:06
@furszy
Copy link
Author

furszy commented May 8, 2020

Rebased

Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK a41da9f

perpetual updating PIVX Core to BTC Core automation moved this from In Progress to Ready May 20, 2020
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK a41da9f

@random-zebra
Copy link

merging...

@random-zebra random-zebra merged commit 93df7ce into PIVX-Project:master May 20, 2020
perpetual updating PIVX Core to BTC Core automation moved this from Ready to Done May 20, 2020
@furszy furszy deleted the 2020_macos_fix_open_files_with_no_default_app branch November 29, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI macOS Issues/problems specifically related to macOS Upstream
Development

Successfully merging this pull request may close these issues.

None yet

3 participants