[Backport] Preemptively catch a few potential bugs #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is easily confused with CCoinsViewCache(CCoinsView*), which creates a sub-cache, but instead of creating a sub-cache, the copy constructor would copy the original and use that original's base, defeating the intended isolation. Coming from upstream@228d2385254ee136ef64d229a414fdd7cefea9a0
random-zebra
added this to In Progress
in perpetual updating PIVX Core to BTC Core
via automation
src/main.cpp
Outdated
Comment on lines
2519
to
2520
| if (!fJustCheck) | ||
| view.SetBestBlock(pindex->GetBlockHash()); |
There was a problem hiding this comment.
No need for this. As if fJustCheck is true, we've already exited the function by now (line 2458).
There was a problem hiding this comment.
yeah good catch. Just dropped the last commit.
furszy
force-pushed
the
2020_backport_5580
branch
from
0e78cda
to
e337706
Compare
Fuzzbawls
approved these changes
May 20, 2020
perpetual updating PIVX Core to BTC Core
automation
moved this from In Progress
to Ready
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes CCoinsViewCache(CCoinsViewCache) to fail at compile-time rather than copy an existing cache (most likely the caller intends to sub-cache it)
It also makes ConnectBlock's fJustCheck work correctly for the genesis block, just in case it gets in there somehow.
Coming from upstream@5580